Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Prowjobs getter considers org w/o https:// prefix #27647

Merged
merged 1 commit into from Sep 29, 2022
Merged

Static Prowjobs getter considers org w/o https:// prefix #27647

merged 1 commit into from Sep 29, 2022

Conversation

chaodaiG
Copy link
Contributor

It's already supported and there are already users specifying Gerrit orgs without https:// prefix, this change is for avoiding breaking backward compatibility

/cc @cjwagner @listx

@chaodaiG
Static Prowjobs getter considers org w/o https:// prefix
c4a2dff 
It's already supported and there are already users specifying Gerrit orgs without https:// prefix, this change is for avoiding breaking backward compatibility
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/branchprotector Issues or PRs related to prow's branchprotector component approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/plugins Issues or PRs related to prow's plugins for the hook component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 28, 2022
listx
listx reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@listx listx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

The comment about deduplicating is a possible future refactor and not blocking.

prow/config/config.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2022
@chaodaiG
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 99179b7 into kubernetes:master Sep 29, 2022
@chaodaiG chaodaiG deleted the gerrit-static-trim-http branch September 29, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@listx listx listx left review comments

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@listx listx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chaodaiG @k8s-ci-robot @listx