Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add External Secret Operator configs #27932

Closed
wants to merge 4 commits into from
Closed

Add External Secret Operator configs #27932

wants to merge 4 commits into from

Conversation

chaodaiG
Copy link
Contributor

@chaodaiG chaodaiG commented Nov 8, 2022

Part of #24869

The goal is to migrate from Kubernetes External Secret to External Secret Operator as the former was announced deprecated and superseded by the latter. This PR adds the configs with the replica set to 0 so it will be no effect.

For code reviewers, this PR consists of two commits:

  • Source control External Secret Operator service, deployment that are generated by helm template. Also copy/pasted external secrets that were used by Kubernetes External Secrets.
  • Modify the new external secrets file to the format that works with External Secret Operator.

@chaodaiG
Source control External Secret Operator at version v0.6.1
dba3ee8 
Generated by running

helm repo add external-secrets-eso https://charts.external-secrets.io
helm template --include-crds --output-dir ./output_dir external-secrets-eso    external-secrets-eso/external-secrets

The only modification is updating the service account name in the deployment.yaml file
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added area/prow/bump Updates to the k8s prow cluster approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chaodaiG
External secrets are added as ESO format
7066dc1
@chaodaiG
yamllint treats multiple space after colon as warning instead of error
393a94f 
This error occurred on generated yaml from External Secret Operator, figure it doesn't worth an error
@ameukam
Copy link
Member

ameukam commented Nov 8, 2022

/lgtm
/hold

Feel to remove the hold when you're ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2022
@jimangel jimangel mentioned this pull request Nov 9, 2022
Open
@chaodaiG
Deploy external secrets operator as part of prow deployment
2c2a211 
They are required for the external secret CR to be deployed in the cluster
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@chaodaiG
Copy link
Contributor Author

As discussed in #24869, CSI driver is probably preferred over ESO

/close

@k8s-ci-robot
Copy link
Contributor

@chaodaiG: Closed this PR.

In response to this:

As discussed in #24869, CSI driver is probably preferred over ESO

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chaodaiG @k8s-ci-robot @ameukam