Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add the redhat-openshift-release-4.12-interop Dashboard to Testgrid" #28593

Merged

Conversation

droslean
Copy link
Member

Reverts #28449

Since it broke our automation, it would be better to revert these changes and fix the generator.

See https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-prow-auto-testgrid-generator/1620210483418107904#1:build-log.txt%3A34

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@droslean
Copy link
Member Author

/cc @calebevans FYI

@k8s-ci-robot
Copy link
Contributor

@droslean: GitHub didn't allow me to request PR reviews from the following users: calebevans, FYI.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @calebevans FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danilo-gemoli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 80b584e into kubernetes:master Jan 31, 2023
@droslean droslean deleted the revert-28449-redhat_mtr_interop branch January 31, 2023 10:06
@calebevans
Copy link
Contributor

@droslean are we going to be able to add our own configs after the generator is fixed?

CC: @ascerra

@droslean
Copy link
Member Author

@droslean are we going to be able to add our own configs after the generator is fixed?

CC: @ascerra

There is nothing to be fixed. Only to extend the generator to support such cases.

@calebevans
Copy link
Contributor

@droslean sounds good, I'll look into what I can do.

@calebevans
Copy link
Contributor

@droslean it looks like the issue is in this line. I can try re-working the automation, but I can also just change the name of the dashboard to not include "-release-". We used the "-release-" initially for consistency, but we don't need it there.

CC: @ascerra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants