Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crio swap: sync the swap configuration #28611

Merged
merged 1 commit into from Feb 2, 2023
Merged

crio swap: sync the swap configuration #28611

merged 1 commit into from Feb 2, 2023

Conversation

haircommander
Copy link
Contributor

as well as hopefully fix the ssh issues

Signed-off-by: Peter Hunt pehunt@redhat.com

@haircommander
crio swap: sync the swap configuration
6f13328 
as well as hopefully fix the ssh issues

Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2023
@haircommander
Copy link
Contributor Author

haircommander commented Feb 1, 2023 •
edited

hopefully fixes crio the login issues of kubernetes/kubernetes#115372

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 1, 2023
@haircommander haircommander mentioned this pull request Feb 1, 2023
Closed
@mmiranda96
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
@pacoxu
Copy link
Member

pacoxu commented Feb 2, 2023 •
edited

/assign @SergeyKanzhelev @dchen1107
for approval

SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

lets see

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8f70866 into kubernetes:master Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

@haircommander: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

as well as hopefully fix the ssh issues

Signed-off-by: Peter Hunt pehunt@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander haircommander mentioned this pull request Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@mmiranda96 mmiranda96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@haircommander @mmiranda96 @pacoxu @k8s-ci-robot @SergeyKanzhelev @dchen1107