Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional go compatibility unit and integration presubmits #28626

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 2, 2023

Related to #28310 and kubernetes/enhancements#3744

  • Clones the unit/integration presubmits for release branches (first commit)
  • Makes them optional and non-blocking, and records the GO_VERSION that release branch originally shipped with (second commit)

Eventually intended to be used in combination with something like kubernetes/kubernetes#115377

Once this is proven out, we can figure out how to keep these created / updated as part of the fork-config script

cc @dims @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 2, 2023
@dims
Copy link
Member

dims commented Feb 3, 2023

@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2023

needs a couple of annotations @liggitt:

ack, put in the sig-testing-canaries dashboard alongside the go-canary jobs for now

@dims
Copy link
Member

dims commented Feb 3, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit fd0bdf1 into kubernetes:master Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

@liggitt: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.23.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.23.yaml
  • key 1.24.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.24.yaml
  • key 1.25.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml
  • key 1.26.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml
  • key make-test.yaml using file config/jobs/kubernetes/sig-testing/make-test.yaml

In response to this:

Related to #28310 and kubernetes/enhancements#3744

  • Clones the unit/integration presubmits for release branches (first commit)
  • Makes them optional and non-blocking, and records the GO_VERSION that release branch originally shipped with (second commit)

Eventually intended to be used in combination with something like kubernetes/kubernetes#115377

Once this is proven out, we can figure out how to keep these created / updated as part of the fork-config script

cc @dims @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants