Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFD: Use kubekins image for e2e #29419

Closed
wants to merge 1 commit into from
Closed

NFD: Use kubekins image for e2e #29419

wants to merge 1 commit into from

Conversation

ArangoGutierrez
Copy link
Contributor

No description provided.

@ArangoGutierrez
NFD: Use kubekins image for e2e
6cda41f 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 4, 2023
@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok May 4, 2023 08:47
@ArangoGutierrez
Copy link
Contributor Author

/cc @marquiz @fmuyassarov

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs labels May 4, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 4, 2023
@ArangoGutierrez ArangoGutierrez mentioned this pull request May 4, 2023
Merged
@fmuyassarov
Copy link
Member

@ArangoGutierrez do we know what are the things that are pre-baked into that image?

@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez do we know what are the things that are pre-baked into that image?

https://github.com/kubernetes/test-infra/blob/9050e0e46b6acb917944a675c5e542d003456b46/images/kubekins-e2e/Dockerfile

fmuyassarov
fmuyassarov reviewed May 4, 2023
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the e2e presubmit my initial plan was to run the tests on a remote server (Equinix Metal3 currently offered by the CNCF) where we will have all the required tooling and binaries already installed. And in Prow, we would need bare minimum just to trigger the script.
So, I'm not sure why we would need things pre-baked in to the https://github.com/kubernetes/test-infra/blob/9050e0e46b6acb917944a675c5e542d003456b46/images/kubekins-e2e/Dockerfile.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor

marquiz commented May 10, 2023

I don't think we need this. -> close?

@fmuyassarov
Copy link
Member

I don't think we need this. -> close?

Yes, I think we can close it.
But let's hear from @ArangoGutierrez .

@ArangoGutierrez
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@kad kad Awaiting requested review from kad

@zvonkok zvonkok Awaiting requested review from zvonkok

@marquiz marquiz Awaiting requested review from marquiz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ArangoGutierrez @k8s-ci-robot @fmuyassarov @marquiz