Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert update to go 1.20 #29471

Merged
merged 1 commit into from
May 9, 2023
Merged

revert update to go 1.20 #29471

merged 1 commit into from
May 9, 2023

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented May 9, 2023 •
edited

Reverts #29383

I think this is causing test failures and is blocking release. We can reintroduce this later after investigation.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2023
@natasha41575
Copy link
Contributor Author

/cc @annasong20

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label May 9, 2023
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 9, 2023
@natasha41575 natasha41575 mentioned this pull request May 9, 2023
Merged
@annasong20
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit c34752a into kubernetes:master May 9, 2023
6 checks passed
@natasha41575 natasha41575 deleted the revert branch May 9, 2023 19:12
@k8s-ci-robot
Copy link
Contributor

@natasha41575: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kustomize-presubmit-master.yaml using file config/jobs/kubernetes-sigs/kustomize/kustomize-presubmit-master.yaml

In response to this:

Reverts #29383

I think this is causing test failures and is blocking release. We can reintroduce this later after investigation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natasha41575 natasha41575 mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annasong20 annasong20 Awaiting requested review from annasong20

@mengqiy mengqiy Awaiting requested review from mengqiy

@phanimarupaka phanimarupaka Awaiting requested review from phanimarupaka

Assignees

@annasong20 annasong20

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@natasha41575 @k8s-ci-robot @annasong20