Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable needs-triage for cloud-provider-gcp #29501

Merged
merged 1 commit into from
May 12, 2023
Merged

enable needs-triage for cloud-provider-gcp #29501

merged 1 commit into from
May 12, 2023

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot requested a review from aojea May 11, 2023 17:44
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 11, 2023
thockin
thockin reviewed May 11, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, SergeyKanzhelev, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SergeyKanzhelev
Copy link
Member

/lgtm

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit dea31fe into kubernetes:master May 12, 2023
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

/hold
/cc @SergeyKanzhelev @aojea @thockin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented May 12, 2023

+1

@BenTheElder BenTheElder deleted the gcp-triage branch May 12, 2023 23:31
@jprzychodzen jprzychodzen mentioned this pull request Jun 7, 2023
Closed
@jprzychodzen
Copy link
Contributor

@BenTheElder It seems that the configuration does not work as expected, please see kubernetes/cloud-provider-gcp#560. Could you help with that?

@jprzychodzen jprzychodzen mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@aojea aojea Awaiting requested review from aojea

Assignees

@thockin thockin

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@BenTheElder @k8s-ci-robot @SergeyKanzhelev @aojea @jprzychodzen @thockin