Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borrow pull-kubernetes-e2e-gce-cos-alpha-features job for ValidatingAdmissionPolicy. #29593

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented May 24, 2023

This PR adds ValidatingAdmissionPolicy to the list of features being tested in job pull-kubernetes-e2e-gce-cos-alpha-features and ci-kubernetes-e2e-gci-gce-alpha-features.

will remove after beta graduation.

Actual tests here kubernetes/kubernetes#114514

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiahuif
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 24, 2023
@jiahuif
Copy link
Member Author

jiahuif commented May 24, 2023

/assign @cheftako @andrewsykim
Could you take a look when available? Thank you.

@jiahuif
Copy link
Member Author

jiahuif commented May 24, 2023

/cc @cici37

@k8s-ci-robot k8s-ci-robot requested a review from cici37 May 24, 2023 18:11
@jiahuif
Copy link
Member Author

jiahuif commented May 25, 2023

/close
in favor of #29599

@k8s-ci-robot
Copy link
Contributor

@jiahuif: Closed this PR.

In response to this:

/close
in favor of 29599

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants