-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPI Operator: use 'run_if_changed' consistently in presubmit jobs #29770
CAPI Operator: use 'run_if_changed' consistently in presubmit jobs #29770
Conversation
…jobs Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
/lgtm |
/cc @dims |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev, furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@furkatgofurov7: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of: kubernetes-sigs/cluster-api-operator#153
we use
run_If_changed
only in one presubmit job to ensure it is not run if only e.g. documentation is changed.This PR makes sure that
run_if_changed
is used consistently in all presubmit jobs that should only be run if our code changes.Changes ensure the following jobs also use
run_if_changed
:Pros of using
run_if_changed
: