Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI Operator: use 'run_if_changed' consistently in presubmit jobs #29770

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Jun 12, 2023

Part of: kubernetes-sigs/cluster-api-operator#153

we use run_If_changed only in one presubmit job to ensure it is not run if only e.g. documentation is changed.
This PR makes sure that run_if_changed is used consistently in all presubmit jobs that should only be run if our code changes.

Changes ensure the following jobs also use run_if_changed:

  • pull-cluster-api-operator-apidiff-main/pull-cluster-api-operator-apidiff-release-0-3
  • pull-cluster-api-operator-test-main/pull-cluster-api-operator-test-release-0-3
  • pull-cluster-api-operator-e2e-main/pull-cluster-api-operator-e2e-release-0-3 (run_if_changed was already in use, regexp was changed to more an explicit one)

Pros of using run_if_changed:

  • less resource usage as we run a lot less jobs
  • less waiting around and re-triggering for test jobs that are not relevant to doc PRs

…jobs

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 12, 2023
@furkatgofurov7
Copy link
Member Author

@Fedosin
Copy link
Contributor

Fedosin commented Jun 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@furkatgofurov7
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 13, 2023 21:03
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6f00dee into kubernetes:master Jun 15, 2023
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-operator-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-presubmits-main.yaml
  • key cluster-api-operator-presubmits-release-0-3.yaml using file config/jobs/kubernetes-sigs/cluster-api-operator/cluster-api-operator-presubmits-release-0-3.yaml

In response to this:

Part of: kubernetes-sigs/cluster-api-operator#153

we use run_If_changed only in one presubmit job to ensure it is not run if only e.g. documentation is changed.
This PR makes sure that run_if_changed is used consistently in all presubmit jobs that should only be run if our code changes.

Changes ensure the following jobs also use run_if_changed:

  • pull-cluster-api-operator-apidiff-main/pull-cluster-api-operator-apidiff-release-0-3
  • pull-cluster-api-operator-test-main/pull-cluster-api-operator-test-release-0-3
  • pull-cluster-api-operator-e2e-main/pull-cluster-api-operator-e2e-release-0-3 (run_if_changed was already in use, regexp was changed to more an explicit one)

Pros of using run_if_changed:

  • less resource usage as we run a lot less jobs
  • less waiting around and re-triggering for test jobs that are not relevant to doc PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furkatgofurov7 furkatgofurov7 deleted the use-run-if-changed-consistently-capioperator branch June 15, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants