Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops tests: support passing --boskos-resource-type flag #29907

Merged
merged 1 commit into from
Jun 22, 2023
Merged

kops tests: support passing --boskos-resource-type flag #29907

merged 1 commit into from
Jun 22, 2023

Conversation

justinsb
Copy link
Member

This flag will trigger kubetest2-kops to acquire the resource from
boskos.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@justinsb
kops tests: support passing --boskos-resource-type flag
46d2956 
This flag will trigger kubetest2-kops to acquire the resource from
boskos.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2023
justinsb
justinsb commented Jun 22, 2023
View reviewed changes
config/jobs/kubernetes/kops/build_jobs.py
@@ -1614,6 +1621,11 @@ def generate_presubmits_e2e():
always_run=False,
use_boskos=True,
),
presubmit_test(
name='presubmit-kops-aws-boskos-kubetest2',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a new presubmit job just to test this out. This doesn't work with scenarios (as we discussed in kOps office hours), so this is not a scenario test.

@justinsb justinsb mentioned this pull request Jun 22, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member Author

Unrelated flake: testing.go:1312: race detected during execution of test --- FAIL:TestHandleIssueCommentEvent/mergeable_no-op

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9efe951 into kubernetes:master Jun 22, 2023
@k8s-ci-robot
Copy link
Contributor

@justinsb: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-presubmits-e2e.yaml using file config/jobs/kubernetes/kops/kops-presubmits-e2e.yaml

In response to this:

This flag will trigger kubetest2-kops to acquire the resource from
boskos.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @k8s-ci-robot @hakman