Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch NPD jobs to GCP-hosted clusters #30262

Merged

Conversation

mmiranda96
Copy link
Contributor

@mmiranda96 mmiranda96 commented Aug 1, 2023

What does this PR do?

Update the cluster for NPD jobs to k8s-infra-prow-build, which is community-owned (some jobs can run in EKS-hosted cluster, but I think it's better to have them all in the same GCP-hosted cluster for consistency reasons).

The only exception is for jobs that require to upload files to a GCS bucket. These jobs will remain on Google-owned cluster default until we are able to grant all the missing permissions to cluster k8s-infra-prow-build:

  • ci-npd-build
  • pull-npd-e2e-node
  • pull-npd-e2e-kubernetes-gce-gci
  • pull-npd-e2e-kubernetes-gce-gci-custom-flags
  • pull-npd-e2e-kubernetes-gce-ubuntu
  • pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

/assign @SergeyKanzhelev
/cc @MartinForReal

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 1, 2023
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

let's revert for now

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmiranda96, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit d1098e7 into kubernetes:master Aug 1, 2023
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@mmiranda96: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-problem-detector-ci.yaml using file config/jobs/kubernetes/node-problem-detector/node-problem-detector-ci.yaml
  • key node-problem-detector-presubmits.yaml using file config/jobs/kubernetes/node-problem-detector/node-problem-detector-presubmits.yaml

In response to this:

What does this PR do?

Update the cluster for NPD jobs to k8s-infra-prow-build, which is community-owned (some jobs can run in EKS-hosted cluster, but I think it's better to have them all in the same GCP-hosted cluster for consistency reasons).

The only exception is for jobs that require to upload files to a GCS bucket. These jobs will remain on Google-owned cluster default until we are able to grant all the missing permissions to cluster k8s-infra-prow-build:

  • ci-npd-build
  • pull-npd-e2e-node
  • pull-npd-e2e-kubernetes-gce-gci
  • pull-npd-e2e-kubernetes-gce-gci-custom-flags
  • pull-npd-e2e-kubernetes-gce-ubuntu
  • pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

/assign @SergeyKanzhelev
/cc @MartinForReal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rjsadow
Copy link
Contributor

rjsadow commented Nov 13, 2023

The only exception is for jobs that require to upload files to a GCS bucket. These jobs will remain on Google-owned cluster default until we are able to grant all the missing permissions to cluster k8s-infra-prow-build:
* ci-npd-build
* pull-npd-e2e-node
* pull-npd-e2e-kubernetes-gce-gci
* pull-npd-e2e-kubernetes-gce-gci-custom-flags
* pull-npd-e2e-kubernetes-gce-ubuntu
* pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

@SergeyKanzhelev @ameukam do you see any reason these jobs can't be moved now? I'm not sure what the original issue with uploading to GCS buckets was but there's nothing that stands out to me about these jobs now that should prevent a migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants