Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add milestone applier for k/website #30389

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

Rishit-dagli
Copy link
Member

@Rishit-dagli Rishit-dagli commented Aug 16, 2023

Add milestone applier configuration for dev-1.29

/kind cleanup
/kind documentation
/cc @kubernetes/sig-docs-leads

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 16, 2023
@divya-mohan0209
Copy link
Contributor

Hey @Rishit-dagli , per this PR by @sftim , branch protection has been enabled, by default, for ALL branches of k/website. Thank you for adding the milestone applier configuration for dev-1.29!

I'd suggest that we document (or undocument) this in the Release team docs role handbook after reconfirming with Tim and/or others on this PR.

Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
@Rishit-dagli Rishit-dagli changed the title Add branch protection and milestone applier for k/website Add milestone applier for k/website Aug 16, 2023
@reylejano
Copy link
Member

This step to apply the milestone applier is part of the release team docs role as stated here: https://github.com/kubernetes/sig-release/blob/master/release-team/role-handbooks/docs/Release-Timeline.md#modify-prow-config-file

The milestone applier will add the 1.29 milestone to any PR in the dev-1.29 branch in k/website
/approve

@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, reylejano, Rishit-dagli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit fb5096b into kubernetes:master Aug 17, 2023
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Rishit-dagli: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Add milestone applier configuration for dev-1.29

/kind cleanup
/kind documentation
/cc @kubernetes/sig-docs-leads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants