Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap image: update to bookworm #30409

Merged
merged 1 commit into from Aug 17, 2023
Merged

bootstrap image: update to bookworm #30409

merged 1 commit into from Aug 17, 2023

Conversation

listx
Copy link
Contributor

@listx listx commented Aug 17, 2023

This notably picks up git 2.39, whose sparse-checkout behavior has git/git@4ce5043.

/cc @cjwagner @timwangmusic @airbornepony

bootstrap image: update to bookworm
fb293ec 
This notably picks up git 2.39, whose sparse-checkout behavior has
git/git@4ce5043.
@k8s-ci-robot
Copy link
Contributor

@listx: GitHub didn't allow me to request PR reviews from the following users: airbornepony.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This notably picks up git 2.39, whose sparse-checkout behavior has git/git@4ce5043.

/cc @cjwagner @timwangmusic @airbornepony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2023
@listx
Copy link
Contributor Author

listx commented Aug 17, 2023

/cc @BenTheElder

@listx
Copy link
Contributor Author

listx commented Aug 17, 2023

For additional context this is the path of least resistance for updating Git in our CI image for making #30400 ready for Git 2.36+. Currently that PR is set to work for Git 2.32-2.36.

@listx listx mentioned this pull request Aug 17, 2023
Merged
BenTheElder
BenTheElder reviewed Aug 17, 2023
View reviewed changes
images/bootstrap/Dockerfile
@@ -14,7 +14,7 @@

# Includes basic workspace setup, with gcloud and a bootstrap runner

FROM debian:bullseye
FROM debian:bookworm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to keep an eye on how CI goes when this filters into kubekins-e2e etc because of e.g. docker getting upgraded

BenTheElder
BenTheElder reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, listx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e81b5a into kubernetes:master Aug 17, 2023
4 of 5 checks passed
@listx listx mentioned this pull request Sep 8, 2023
Merged
ameukam added a commit to ameukam/test-infra that referenced this pull request Sep 12, 2023
@ameukam
images/bootstrap: Allow pip an external python installation
ee20a1f 
Follow of:
  - kubernetes#30409

the image failed to build with:

```
Step #1: ╰─> To install Python packages system-wide, try apt install
Step #1:     python3-xyz, where xyz is the package you are trying to
Step #1:     install.
Step #1:
Step #1:     If you wish to install a non-Debian-packaged Python package,
Step #1:     create a virtual environment using python3 -m venv path/to/venv.
Step #1:     Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
Step #1:     sure you have python3-full installed.
Step #1:
Step #1:     If you wish to install a non-Debian packaged Python application,
Step #1:     it may be easiest to use pipx install xyz, which will manage a
Step #1:     virtual environment for you. Make sure you have pipx installed.
Step #1:
Step #1:     See /usr/share/doc/python3.11/README.venv for more information.
```

Starting with bookworm, pip enforces [PEP 668](https://peps.python.org/pep-0668/).

This is an attempt to ensure we don't break python packages
installation.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@cjwagner cjwagner Awaiting requested review from cjwagner

@timwangmusic timwangmusic Awaiting requested review from timwangmusic

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@listx @k8s-ci-robot @BenTheElder