-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new optional gce cos presubmit test #30703
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
53d5e2b
to
41aced4
Compare
41aced4
to
278ae6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--tooling=kops
is still pending review. It can be added in a future PR.
@@ -62,8 +62,7 @@ | |||
{%- endif %} | |||
--test=kops \ | |||
-- \ | |||
--ginkgo-args="--debug" \ | |||
--test-args="-test.timeout={{test_timeout}} -num-nodes=0" \ | |||
--test-args="-test.timeout={{test_timeout}} -num-nodes=0 --tooling=kops" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--test-args="-test.timeout={{test_timeout}} -num-nodes=0 --tooling=kops" \ | |
--test-args="-test.timeout={{test_timeout}} -num-nodes=0" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the k/k PR closely, the flag already exists but it hasn't been used till my PR. Setting a value is fine and it will do something useful as soon as the change is merged.
@@ -66,8 +66,7 @@ | |||
{%- endif %} | |||
--test=kops \ | |||
-- \ | |||
--ginkgo-args="--debug" \ | |||
--test-args="-test.timeout={{test_timeout}} -num-nodes=0" \ | |||
--test-args="-test.timeout={{test_timeout}} -num-nodes=0 --tooling=kops" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--test-args="-test.timeout={{test_timeout}} -num-nodes=0 --tooling=kops" \ | |
--test-args="-test.timeout={{test_timeout}} -num-nodes=0" \ |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
--debug
flag for ginkgo is deprecated--tooling=kops
allows us to do things like this Skip kube-up related GCE tests when running e2e tests on kops kubernetes#120628