Disable pprof debug endpoint #31006
Merged
Disable pprof debug endpoint #31006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
listx
reviewed
Oct 11, 2023
| @@ -35,8 +35,9 @@ import ( | |||
| ) | |||
|
|
|||
| func serveOnPort(ctx context.Context, storageClient *storage.Client, predictor *predictionClient, port int, timeout time.Duration) error { | |||
| mux := http.NewServeMux() | |||
There was a problem hiding this comment.
For the record, it looks like using our own ServeMux avoids using the DefaultServeMux which is used otherwise. DefaultServeMux exposes the pprof endpoints, which we want to avoid. References: https://stackoverflow.com/a/36249058/437583 https://pkg.go.dev/net/http#hdr-Servers
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcswebshouldn't expose/debug/pprof/that contains memory addresses and more.I'v also noticed the default mux was exposing it in
mlexperiment so I addressed it as well.Similarly this was already fixed in
kubeletin kubernetes/kubernetes#81023 (CVE-2019-11248) and parts of prow in #24105