Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e etcd presubmit #31257

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

upodroid
Copy link
Member

/cc @serathius @ahrtr
@etsrpl

The presubmit jobs I introduced in #31218 are stable now and I made them required now.

I also introduced an e2e presubmit for someone to fix the bugs in the ci-etcd-e2e-amd64 job.

https://testgrid.k8s.io/sig-etcd-periodics#ci-etcd-e2e-amd64

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 16, 2023
@serathius
Copy link
Contributor

/lgtm
This is awesome

Thanks for helping us with this, great to see so fast progress.

My only concern is proper planning and coordination. Making sure that the end result helps etcd project and we don't have any loose ends. Answering questions like:

Do we plan to replace all the workflows? Are we sure all workflows can be migrated or are there any missing features in prow (like arm64 nodes)? Do we support two separate CI? Or we should start removing duplicated workflows now? How and where do we document the new CI so contributors can adjust? @jmhbnz could you help with that?

/hold
for @ahrtr review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent progress, thanks for the help with this @upodroid.

My only concern is proper planning and coordination. Making sure that the end result helps etcd project and we don't have any loose ends.

Agree @serathius - We probably need a second iteration of a CI improvements umbrella issue to plan out the rest of the work and make sure we can communicate all the changes to the rest of the project and make sure everyone understands.

I will try to spend some time in the coming few days on planning and documenting.

@ahrtr
Copy link
Member

ahrtr commented Nov 17, 2023

/lgtm
/approve

Thanks.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8e210ca into kubernetes:master Nov 17, 2023
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

/cc @serathius @ahrtr
@etsrpl

The presubmit jobs I introduced in #31218 are stable now and I made them required now.

I also introduced an e2e presubmit for someone to fix the bugs in the ci-etcd-e2e-amd64 job.

https://testgrid.k8s.io/sig-etcd-periodics#ci-etcd-e2e-amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upodroid
Copy link
Member Author

My only concern is proper planning and coordination. Making sure that the end result helps etcd project and we don't have any loose ends. Answering questions like:

Do we plan to replace all the workflows? Are we sure all workflows can be migrated or are there any missing features in prow (like arm64 nodes)? Do we support two separate CI? Or we should start removing duplicated workflows now? How and where do we document the new CI so contributors can adjust? @jmhbnz could you help with that?

I'll open one to track all the integration work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants