don't enable node-problem-local detector on dns jobs

[aojea]

Since NPD changed to be a daemonset and the workers are small, sometimes there is no room on the nodes for the pods to be scheduled and the job times out

These jobs test DNS, so no need to install node problem detector.

[aojea]

/assign @upodroid @ameukam

[ameukam]

/lgtm

[upodroid]

There is an open PR in k/k to have the master/control-plane use e2-standard-2 and the nodes to use e2-standard-2. double the cores for control plane instance

kubernetes/kubernetes#118626

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-network/OWNERS [aojea,upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

is this related?

k8s.io/test-infra/prow/config/secret: TestAddWithParser/1 expand_less

2s

{Failed === RUN TestAddWithParser/1 === PAUSE TestAddWithParser/1 === CONT TestAddWithParser/1 time="2023-XX-24TXX:X2:00Z" level=warning msg="Error loading secret file." error="stat /tmp/X742X67904: no such file or directory" secret-path=/tmp/X742X67904 time="2023-XX-24TXX:X2:00Z" level=warning msg="Error loading secret file." error="stat /tmp/3086003526: no such file or directory" secret-path=/tmp/3086003526 agent_test.go:169: expected value 2 from generator, got 1 time="X0X3-11-X4T11:1X:01Z" level=error msg="Error loading secret." error="strconv.Atoi: parsing "not-a-number": invalid syntax" secret-path=/tmp/TestAddWithParser0360X481105/001/secret --- FAIL: TestAddWithParser/1 (2.00s)

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/31312/pull-test-infra-unit-test/1728007651314372608

[aojea]

/test pull-test-infra-unit-test

[k8s-ci-robot]

@aojea: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml

In response to this:

Since NPD changed to be a daemonset and the workers are small, sometimes there is no room on the nodes for the pods to be scheduled and the job times out

These jobs test DNS, so no need to install node problem detector.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

It does not seem to make effect https://testgrid.k8s.io/sig-network-gce#gci-gce-coredns-nodecache , it keeps installing the node problem detector

[upodroid]

It does not seem to make effect https://testgrid.k8s.io/sig-network-gce#gci-gce-coredns-nodecache , it keeps installing the node problem detector

You used the wrong variable

https://github.com/kubernetes/kubernetes/blob/d61cbac69aae97db1839bd2e0e86d68f26b353a7/cluster/gce/config-default.sh#L290

export ENABLE_NODE_PROBLEM_DETECTOR="${KUBE_ENABLE_NODE_PROBLEM_DETECTOR:-daemonset}"

[aojea]

It does not seem to make effect https://testgrid.k8s.io/sig-network-gce#gci-gce-coredns-nodecache , it keeps installing the node problem detector

You used the wrong variable

https://github.com/kubernetes/kubernetes/blob/d61cbac69aae97db1839bd2e0e86d68f26b353a7/cluster/gce/config-default.sh#L290

export ENABLE_NODE_PROBLEM_DETECTOR="${KUBE_ENABLE_NODE_PROBLEM_DETECTOR:-daemonset}"

:facepalm