Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create kubekins v2 image #31421

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Create kubekins v2 image #31421

merged 1 commit into from
Feb 7, 2024

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Dec 11, 2023 •
edited
Loading

I'm creating a new version of the kubekins-e2e image that can immediately replace the kubekins image usage everywhere except k/k e2e jobs and few jobs that rely on legacy tooling.

New features:

  1. lean image
  2. multi-arch (etcd e2e requires an arm64 image)
  3. all the legacy CI cruft is gone

Fixes: #31273

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@k8s-ci-robot k8s-ci-robot added area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Dec 11, 2023
@upodroid
Copy link
Member Author

/cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

@upodroid: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-engineering.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upodroid
Copy link
Member Author

/hold

I need to create the prowjobs and the bumper for the new image. I'll cancel this hold once that PR is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
This was referenced Dec 11, 2023
Open
Merged
@upodroid
Copy link
Member Author

/retest

@upodroid
Copy link
Member Author

Hello, can I get lgtm on this PR please?

@upodroid
Copy link
Member Author

/cc @dims

@dims
Copy link
Member

dims commented Jan 11, 2024

cc @BenTheElder @aojea @michelle192837 @jbpratt

xmudrii
xmudrii reviewed Jan 11, 2024
View reviewed changes
images/kubekins-e2e-v2/variants.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update this for the latest Go releases before merging (xref #31602)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jbpratt
Copy link
Contributor

jbpratt commented Jan 12, 2024

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
cpanato
cpanato reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits

images/kubekins-e2e-v2/Dockerfile Outdated Show resolved Hide resolved
images/kubekins-e2e-v2/Makefile Outdated Show resolved Hide resolved
images/kubekins-e2e-v2/runner.sh Outdated Show resolved Hide resolved
@AndrewSirenko AndrewSirenko mentioned this pull request Feb 6, 2024
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@upodroid
Copy link
Member Author

upodroid commented Feb 7, 2024

The infra is ready, need a LGTM

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@dims
Copy link
Member

dims commented Feb 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 142dd0c into kubernetes:master Feb 7, 2024
5 checks passed
@upodroid upodroid mentioned this pull request Feb 7, 2024
Merged
@upodroid upodroid mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@xmudrii xmudrii xmudrii left review comments

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@jbpratt jbpratt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create arm64 version of the kubekins-e2e and bootstrap image
6 participants
@upodroid @k8s-ci-robot @dims @jbpratt @cpanato @xmudrii