Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job: migrate pull-alibaba-cloud-csi-driver-verify to community cluster #31839

Conversation

Okabe-Junya
Copy link
Member

ref. #31795

Feature Description

  • migrate pull-alibaba-cloud-csi-driver-verify from gke to community cluster
    • pull-alibaba-cloud-csi-driver-verify-fmt
    • pull-alibaba-cloud-csi-driver-verify-lint
    • pull-alibaba-cloud-csi-driver-verify-vet
    • pull-alibaba-cloud-csi-driver-verify-unit

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 5, 2024
@Okabe-Junya
Copy link
Member Author

/retitle job: migrate pull-alibaba-cloud-csi-driver-verify to community cluster

@k8s-ci-robot k8s-ci-robot changed the title job: migrate pull-alibaba-cloud-csi-driver-verify to community cluster job: migrate pull-alibaba-cloud-csi-driver-verify to community cluster Feb 5, 2024
@Okabe-Junya
Copy link
Member Author

/cc @rjsadow

@Okabe-Junya
Copy link
Member Author

Okabe-Junya commented Feb 5, 2024

/cc @ameukam

ref. kubernetes/kubernetes#123079 (comment)

Please pick one prowjob at the time and tag me in the PR for review.
Multiple attempts to migrate are completely OK. we are not expecting people to be successful on the first try.

@rjsadow
Copy link
Contributor

rjsadow commented Feb 5, 2024

/lgtm
@Okabe-Junya, please monitor these jobs via https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?orgId=1&refresh=30s after this is merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@Okabe-Junya
Copy link
Member Author

Thank you~~!!

please monitor these jobs via https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?orgId=1&refresh=30s after this is merged.

Okay, I understand.

/assign @fredkan

@ameukam
Copy link
Member

ameukam commented Feb 5, 2024

/lgtm @Okabe-Junya, please monitor these jobs via https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?orgId=1&refresh=30s after this is merged.

@Okabe-Junya You will not be able to monitor this through https://monitoring-eks.prow.k8s.io/ (This meant for an EKS cluster, the migration target a GKE cluster)
Use https://testgrid.k8s.io/presubmits-alibaba-cloud-csi-driver instead.

@rjsadow
Copy link
Contributor

rjsadow commented Feb 5, 2024

🤥 sorry about that!

@Okabe-Junya
Copy link
Member Author

Okabe-Junya commented Feb 5, 2024

It's ok!! Thank you for inform :)

@ameukam
Copy link
Member

ameukam commented Feb 7, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1cde6b9 into kubernetes:master Feb 7, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Okabe-Junya: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key alibaba-cloud-csi-driver.yaml using file config/jobs/kubernetes-sigs/alibaba-cloud-csi-driver/alibaba-cloud-csi-driver.yaml

In response to this:

ref. #31795

Feature Description

  • migrate pull-alibaba-cloud-csi-driver-verify from gke to community cluster
    • pull-alibaba-cloud-csi-driver-verify-fmt
    • pull-alibaba-cloud-csi-driver-verify-lint
    • pull-alibaba-cloud-csi-driver-verify-vet
    • pull-alibaba-cloud-csi-driver-verify-unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Okabe-Junya Okabe-Junya deleted the migrate-pull-alibaba-cloud-csi-driver-verify-fmt branch February 7, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants