Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NPD presubmit jobs to k8s-infra-prow-build #32228

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

wangzhen127
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@wangzhen127
Copy link
Member Author

/assign @hakman

@hakman
Copy link
Member

hakman commented Mar 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1b45d27 into kubernetes:master Mar 11, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@wangzhen127: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-problem-detector-presubmits.yaml using file config/jobs/kubernetes/node-problem-detector/node-problem-detector-presubmits.yaml

In response to this:

Issue ref: kubernetes/kubernetes#119211

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127
Copy link
Member Author

I still see 403 Forbidden issue.

ERROR: failed to solve: failed to push gcr.io/node-problem-detector-staging/pr/pr1767203130241454080-20240311.145725.072553151/node-problem-detector:v0.8.16-16-ge396aee: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://gcr.io/v2/token?scope=repository%3Anode-problem-detector-staging%2Fpr%2Fpr1767203130241454080-20240311.145725.072553151%2Fnode-problem-detector%3Apull%2Cpush&service=gcr.io: 403 Forbidden
make: *** [Makefile:264: push-container] Error 1

Reverting...

@ameukam
Copy link
Member

ameukam commented Mar 11, 2024

@wangzhen127 I don't see the value of push an artifact during presubmit. The build should be enough ?

@wangzhen127
Copy link
Member Author

While we are reverting the PR, I wonder why ci-npd-e2e-kubernetes-gce-gci can use k8s-infra-prow-build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants