Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cloud provider kind job #32495

Merged
merged 1 commit into from Apr 24, 2024
Merged

add cloud provider kind job #32495

merged 1 commit into from Apr 24, 2024

Conversation

aojea
Copy link
Member

@aojea aojea commented Apr 23, 2024

The existing e2e jobs now are generic enough to pass with the cloud provider kind implementation

kubernetes/kubernetes#124161

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2024
@aojea aojea mentioned this pull request Apr 23, 2024
Open
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 23, 2024
@aojea
Copy link
Member Author

aojea commented Apr 24, 2024

/assign @BenTheElder @danwinship

@danwinship
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 774d1b2 into kubernetes:master Apr 24, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@aojea: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-kind.yaml using file config/jobs/kubernetes/sig-network/sig-network-kind.yaml

In response to this:

The existing e2e jobs now are generic enough to pass with the cloud provider kind implementation

kubernetes/kubernetes#124161

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadmuxe cadmuxe Awaiting requested review from cadmuxe

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@danwinship danwinship

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aojea @k8s-ci-robot @danwinship @BenTheElder