-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPV: adjust resource consumption for jobs on community cluster #32584
CAPV: adjust resource consumption for jobs on community cluster #32584
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -116,10 +116,10 @@ periodics: | |||
resources: | |||
requests: | |||
cpu: "4000m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set limits on some more jobs? I think a bunch of them only have requests (including upgrade jobs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the jobs without limits are only the ones still running on GCP.
I would not invest time in optimizing those jobs because we have to migrate them soonish and also because AFAIK we don't have the same monitoring data that we get for jobs running in EKS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, we have no monitoring data for these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah kk. Missed that we don't have data
/lgtm |
/hold cancel |
@chrischdi: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Part of kubernetes-sigs/cluster-api-provider-vsphere#2978
xref: used sheet: https://docs.google.com/spreadsheets/d/18jQgOlhtMbOICJyMFr_gdI3WlhI0kYmuiEMJuKF61dg/edit#gid=1987539428
/assign @sbueringer