Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled owners-label/verify-owners plugin for etcd-io #32589

Merged
merged 1 commit into from
May 9, 2024

Conversation

liangyuanpeng
Copy link
Contributor

part of etcd-io/etcd#17970
/assign @jmhbnz

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liangyuanpeng
Copy link
Contributor Author

/sig etcd

@k8s-ci-robot k8s-ci-robot added the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label May 9, 2024
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @liangyuanpeng
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@jmhbnz
Copy link
Member

jmhbnz commented May 9, 2024

Based on the failure it looks like we would also need verify-owners?

{"component":"checkconfig","file":"sigs.k8s.io/prow/cmd/checkconfig/main.go:91","func":"main.reportWarning","level":"warning","msg":"the following orgs or repos enable at least one plugin that uses OWNERS files (approve, blunderbuss, owners-label) but do not enable the verify-owners plugin to ensure validity of OWNERS files: [org: etcd-io]","severity":"warning","time":"2024-05-09T08:07:54Z"}

Ref: https://prow.k8s.io/plugins

The verify-owners plugin validates OWNERS and OWNERS_ALIASES files (by default) and ensures that they always contain collaborators of the org, if they are modified in a PR.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@jmhbnz
Copy link
Member

jmhbnz commented May 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@liangyuanpeng liangyuanpeng changed the title enabled owners-label plugin for etcd. enabled owners-label plugin for etcd-io May 9, 2024
@liangyuanpeng liangyuanpeng changed the title enabled owners-label plugin for etcd-io enabled owners-label/verify-owners plugin for etcd-io May 9, 2024
@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented May 9, 2024

@jmhbnz is a approver of etcd, so lgtm is engough (I think?).

looking for approval for this file, @dims ,Thanks :)

@dims
Copy link
Member

dims commented May 9, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jmhbnz, liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 78b8f5d into kubernetes:master May 9, 2024
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@liangyuanpeng: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

part of etcd-io/etcd#17970
/assign @jmhbnz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants