Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubespray: enable plugins release-note, cherrypicker, mergecommitblocker, override #32612

Merged
merged 4 commits into from
May 19, 2024
Merged

kubespray: enable plugins release-note, cherrypicker, mergecommitblocker, override #32612

merged 4 commits into from
May 19, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 14, 2024

This should help us (the kubespray maintainers) automate some of the tedious stuff

wdyt ?
/cc @yankay @mzaian @MRFreezex @floryut

@VannTen
Enable release-note plugin for kubernetes-sigs/kubespray
b5a54aa 
Should help babysitting PR, freeing maintainers time.

Signed-off-by: Max Gautier <mg@max.gautier.name>
@VannTen
Enable cherrypicker plugin for kubernetes-sigs/kubespray
c58b1b1 
More automation for kubespray maintenance

Signed-off-by: Max Gautier <mg@max.gautier.name>
@k8s-ci-robot
Copy link
Contributor

@VannTen: GitHub didn't allow me to request PR reviews from the following users: floryut.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This should help us (the kubespray maintainers) automate some of the tedious stuff

wdyt ?
/cc @yankay @mzaian @MRFreezex @floryut

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 14, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 14, 2024

/cc @MrFreezeex
(typo)

@k8s-ci-robot
Copy link
Contributor

@VannTen: GitHub didn't allow me to request PR reviews from the following users: MrFreezeex.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @MrFreezeex
(typo)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mzaian
mzaian approved these changes May 14, 2024
View reviewed changes
Copy link

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 14, 2024 via email

@mzaian
Copy link

mzaian commented May 14, 2024

/cc @yankay

@yankay
Copy link
Member

yankay commented May 15, 2024

Thanks @VannTen
It's great help
/lgtm

@VannTen
kubespray: enable mergecommitblocker
3822991 
Save us from manually blocking PRs
@VannTen
kubespray: enable override
a1b6a57 
Kubespray has a capricious CI, which is also unable to filter for docs
only changes for instances. This will help the maintainers not
restarting unnecessary CI runs, freeing some resources.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@VannTen VannTen changed the title kubespray: enable release-note and cherrypicker kubespray: enable plugins release-note, cherrypicker, mergecommitblocker, override May 17, 2024
@VannTen VannTen requested a review from mzaian May 17, 2024 12:13
mzaian
mzaian approved these changes May 19, 2024
View reviewed changes
Copy link

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2024
@dims
Copy link
Member

dims commented May 19, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit b8529a6 into kubernetes:master May 19, 2024
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@VannTen: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

This should help us (the kubespray maintainers) automate some of the tedious stuff

wdyt ?
/cc @yankay @mzaian @MRFreezex @floryut

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

El-o-heka
El-o-heka approved these changes May 29, 2024
View reviewed changes
Copy link

@El-o-heka El-o-heka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#}°¥°{#🕯️✨📜🗝️⚔️🛡️[„••„]

@k8s-ci-robot
Copy link
Contributor

@El-o-heka: changing LGTM is restricted to collaborators

In response to this:

#}°¥°{#🕯️✨📜🗝️⚔️🛡️[„••„]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, El-o-heka, mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay yankay mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@El-o-heka El-o-heka El-o-heka approved these changes

@yankay yankay Awaiting requested review from yankay

Assignees

@dims dims

@mzaian mzaian

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@VannTen @k8s-ci-robot @mzaian @yankay @dims @El-o-heka