-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kubemark 1.26 test #32628
Remove kubemark 1.26 test #32628
Conversation
It's consistently failing and pinging scalability oncall.
/lgtm |
/assign @cici37 |
Would you mind sharing the failed job and the reason of failing as well? We normally remove 1.26 related tests entirely after the end of support instead of deleting one job. And I believe 1.26 has reached the end of the support cycle. Maybe @xmudrii would know when it will be removed? :) |
We should perhaps remove those jobs ASAP, given that 1.26 is EOL for a while now. I can look into that tomorrow. I don't have strong opinions on this PR, should be fine to proceed to avoid annoying folks, the whole file will be removed soon anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't usually do this, but see #32628 (comment)
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, serathius, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@serathius: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sure, but it's still pinging scalability, so if the release team didn't clean whole test suite, we will clean just our tests. |
It's consistently failing and pinging scalability oncall.
cc @mborsz @jprzychodzen