Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubemark 1.26 test #32628

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

serathius
Copy link
Contributor

It's consistently failing and pinging scalability oncall.

cc @mborsz @jprzychodzen

It's consistently failing and pinging scalability oncall.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 17, 2024
@mborsz
Copy link
Member

mborsz commented May 17, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@serathius
Copy link
Contributor Author

/assign @cici37

@cici37
Copy link
Contributor

cici37 commented May 20, 2024

Would you mind sharing the failed job and the reason of failing as well?

We normally remove 1.26 related tests entirely after the end of support instead of deleting one job. And I believe 1.26 has reached the end of the support cycle. Maybe @xmudrii would know when it will be removed? :)

@xmudrii
Copy link
Member

xmudrii commented May 20, 2024

We should perhaps remove those jobs ASAP, given that 1.26 is EOL for a while now. I can look into that tomorrow. I don't have strong opinions on this PR, should be fine to proceed to avoid annoying folks, the whole file will be removed soon anyways.

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually do this, but see #32628 (comment)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, serathius, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7d2377c into kubernetes:master May 20, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@serathius: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.26.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml

In response to this:

It's consistently failing and pinging scalability oncall.

cc @mborsz @jprzychodzen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Contributor Author

Sure, but it's still pinging scalability, so if the release team didn't clean whole test suite, we will clean just our tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants