Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMM: changing the merge method to rebase. #32790

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Jun 19, 2024

When publishing a new release, multiple commits are going to be cherry-picked from the main branch.

With the previous squash merge method, all those commits would squash to a single huge commit message which is difficult to follow, blame and polluted with multiple signatures.

With this change, we should get a much cleaner git history.

In order to mitigate the risk that comes with the rebase merge methods, we have a CI job that validates that each PR contain a single commit to ensure we don't merge multiple "garbage" commits for a single change in a PR.

--

/cc @qbarrand

When publishing a new release, multiple commits are going to be
cherry-picked from the main branch.

With the previous `squash` merge method, all those commits would squash
to a single huge commit message which is difficult to follow, blame and
polluted with multiple signatures.

With this change, we should get a much cleaner git history.

In order to mitigate the risk that comes with the `rebase` merge methods,
we have a CI job that validates that each PR contain a single commit to
ensure we don't merge multiple "garbage" commits for a single change in
a PR.

Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 19, 2024
@qbarrand
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2024
@ybettan
Copy link
Contributor Author

ybettan commented Jun 19, 2024

/assign @cblecker

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3940d21 into kubernetes:master Jun 19, 2024
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ybettan: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

When publishing a new release, multiple commits are going to be cherry-picked from the main branch.

With the previous squash merge method, all those commits would squash to a single huge commit message which is difficult to follow, blame and polluted with multiple signatures.

With this change, we should get a much cleaner git history.

In order to mitigate the risk that comes with the rebase merge methods, we have a CI job that validates that each PR contain a single commit to ensure we don't merge multiple "garbage" commits for a single change in a PR.

--

/cc @qbarrand

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ybettan ybettan deleted the kmm-rebase branch June 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants