Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-testing: keep the canary job identical to the normal job #32907

Closed
wants to merge 1 commit into from

Conversation

carlory
Copy link
Member

@carlory carlory commented Jul 4, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 4, 2024
@carlory
Copy link
Member Author

carlory commented Jul 4, 2024

/cc @aojea @pohly

@k8s-ci-robot k8s-ci-robot requested review from aojea and pohly July 4, 2024 16:39
@aojea
Copy link
Member

aojea commented Jul 4, 2024

we can keep the canary running more tests, it is optional and can be used to get signal on PRs ... the problem is the other way around, if the normal job runs more tests than the canary 😄

@carlory
Copy link
Member Author

carlory commented Jul 5, 2024

Thanks for review @aojea

If so, is it ready to merge #32867? @pohly

/close

@k8s-ci-robot
Copy link
Contributor

@carlory: Closed this PR.

In response to this:

Thanks for review @aojea

If so, is it ready to merge #32867? @pohly

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants