Don't delete .git when cleaning the workspace. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't we try this once and have issues? |
|
We tried doing a shallow clone and had issues. |
|
XML diff matches expectations: https://travis-ci.org/kubernetes/test-infra/builds/156383088#L408 |
|
The |
This means a full clone isn't necessary, reducing the likelihood that Github will rate-limit our repository.
|
Oops, fixed the other one. This is only hitting a few of the builds, so if it fails (hopefully won't!) it won't be as catastrophic. |
fejta
added
the
lgtm
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means a full clone isn't necessary, reducing the likelihood that
Github will rate-limit our repository.
I manually added this to the kubernetes-pull-verify-all job for testing, and it seems to be working fine. The git plugin Does The Right Thing when .git already exists.
This change is