Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssh key to pull-ingress-gce-e2e #6093

Merged
merged 2 commits into from
Dec 27, 2017

Conversation

BenTheElder
Copy link
Member

fixes job added in #6072

/area jobs

@k8s-ci-robot k8s-ci-robot added area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2017
@BenTheElder
Copy link
Member Author

/cc @rramkumar1

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: GitHub didn't allow me to request PR reviews from the following users: rramkumar1.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rramkumar1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2017
@BenTheElder
Copy link
Member Author

/hold
need to bump image when #6082 goes in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2017
@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, rramkumar1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2017
@BenTheElder
Copy link
Member Author

BenTheElder commented Dec 27, 2017

¯\_(ツ)_/¯

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2017
@k8s-ci-robot k8s-ci-robot merged commit 5dd55f3 into kubernetes:master Dec 27, 2017
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: I updated Prow config for you!

In response to this:

fixes job added in #6072

/area jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the fix-ingress-gce-e2e branch January 31, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants