Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move failing-test from priority to kind label #6642

Closed
wants to merge 1 commit into from
Closed

Move failing-test from priority to kind label #6642

wants to merge 1 commit into from

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Feb 5, 2018 •
edited

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2018
@cblecker cblecker mentioned this pull request Feb 5, 2018
Closed
fejta
fejta reviewed Feb 5, 2018
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Is there a process we want to follow for these sorts of changes?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2018
@cblecker
Copy link
Member Author

cblecker commented Feb 5, 2018

Yeah I don’t want to officially merge this until we get a thumbs up at contribex and communicate it.

@fejta
Copy link
Contributor

fejta commented Feb 5, 2018

Actually looks like the issue exists for discussion. Feel free to /hold cancel whenever you are satisfied with the discussion over there.

@cblecker cblecker closed this Feb 23, 2018
@cblecker
Copy link
Member Author

Gonna handle this more holistically.

@cblecker cblecker deleted the failing-test-label branch February 23, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

Assignees

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cblecker @k8s-ci-robot @fejta