Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for kops with aws-encryption-provider plugin #7821

Closed
wants to merge 1 commit into from
Closed

Add test for kops with aws-encryption-provider plugin #7821

wants to merge 1 commit into from

Conversation

sethpollack
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sethpollack
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: krzyzacy

Assign the PR to them by writing /assign @krzyzacy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2018
@sethpollack
Copy link
Author

/assign @justinsb

@sethpollack sethpollack force-pushed the encryption-provider branch 2 times, most recently from 03286ff to 974927f Compare April 22, 2018 17:16
oomichi
oomichi reviewed Jun 2, 2018
View reviewed changes
jobs/config.json
"--env=KOPS_FEATURE_FLAGS=+EnableKMSPlugin",
"--extract=ci/latest",
"--ginkgo-parallel",
"--kops-etcd-version=3.1.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify the etcd version here?
--kops-etcd-version=3.1.10 is specified at ci-kubernetes-e2e-kops-aws-canary only and that comes from 1075307

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, etcd v3 is a requirement for this test.

oomichi
oomichi reviewed Jun 2, 2018
View reviewed changes
prow/config.yaml Outdated
agent: kubernetes
name: ci-kubernetes-e2e-kops-aws-encryption-provider
labels:
preset-service-account: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to change true to "true" as 1dd7bf4

prow/config.yaml Outdated
name: ci-kubernetes-e2e-kops-aws-encryption-provider
labels:
preset-service-account: true
preset-aws-ssh: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

prow/config.yaml Outdated
labels:
preset-service-account: true
preset-aws-ssh: true
preset-aws-credential: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@BenTheElder
Copy link
Member

/sig aws
/cc @justinsb
@justinsb if not you, can you point me to who should review this from kops/aws side?

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Jun 8, 2018
@fejta
Copy link
Contributor

fejta commented Jun 19, 2018

Looks like this is ready for another round of reviews? (Seth, consider adding a Done comment or something like that when you address previous feedback)

/assign @oomichi
@kubernetes/sig-aws-misc

@sethpollack
Copy link
Author

will do

@k8s-ci-robot
Copy link
Contributor

@sethpollack: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 20, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

@oomichi oomichi

Labels
area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sethpollack @k8s-ci-robot @BenTheElder @fejta @fejta-bot @oomichi @justinsb