Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable federated-build while quinton-hoole fixes its leakiness. #793

Closed
wants to merge 1 commit into from

Conversation

rmmh
Copy link
Contributor

@rmmh rmmh commented Oct 11, 2016

This change is Reviewable

@rmmh rmmh assigned ghost Oct 11, 2016
@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2016
@spxtr
Copy link
Contributor

spxtr commented Oct 11, 2016

I don't think that job template knows what disable_job means.

@madhusudancs
Copy link
Contributor

@rmmh @quinton-hoole Why disable it? It is hard to debug once we do that.

@ghost
Copy link

ghost commented Oct 12, 2016

Never mind. I think I fixed the leak without needing this (kubernetes/kubernetes#34652). Closing.

@ghost ghost closed this Oct 12, 2016
ostromart pushed a commit to ostromart/test-infra that referenced this pull request Jul 26, 2019
grantr pushed a commit to grantr/test-infra that referenced this pull request Feb 21, 2020
* Determine the OS we're running on

Set IS_LINUX, IS_OSX and IS_WINDOWS accordingly.

* Display unknown $OSTYPE on error
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants