Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup branch protection rules for kep14 repos #9291

Merged
merged 1 commit into from Sep 6, 2018
Merged

Setup branch protection rules for kep14 repos #9291

merged 1 commit into from Sep 6, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 6, 2018

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow labels Sep 6, 2018
@cblecker
Copy link
Member

cblecker commented Sep 6, 2018

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Sep 6, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1972a2b into kubernetes:master Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

ref: kubernetes/org#56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the add-kep14-repos branch September 6, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@spxtr spxtr Awaiting requested review from spxtr

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spiffxp @cblecker @k8s-ci-robot