Bump images for k/k master to go1.10.4 #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r|experimental|releases) (using generate_tests and manual)
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
area/images
cncf-cla: yes
BenTheElder
reviewed
Sep 19, 2018
| BAZEL ?= 0.16.1 | ||
| UPGRADE_DOCKER ?=false | ||
| # TODO(bentheelder,cblecker): this is aging and bad | ||
| CFSSL ?= R1.2 | ||
|
|
||
| # config for testing prior to rolling out to master / ongoing release | ||
| ifeq ($(K8S), experimental) | ||
| GO = 1.10.2 | ||
| GO = 1.10.4 |
There was a problem hiding this comment.
as mentioned, we should upgrade this to the latest stable go, but i'll do this in another PR, experimental images are orthogonal here.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
|
(or guess it's fine for OSS) |
|
I'm a bit worried by the size of storage merge for v1.12 today. I want to see the test results there still showing ok this morning, and then intend to unhold this PR this afternoon. Need the team to watch test results especially closely for a good 72hrs after this as it may have not just simpler immediate master branch and quickly following release-1.12 branch issues, but long running scalability issues. |
|
This will only go in if we go to put in kubernetes/kubernetes#68802 which is not currently in the milestone. I think probably we do want to put both in though. |
|
FYI, kubernetes/kubernetes#68802 was just unblocked for merge into k/k. Will be merged after retests. Please stand by :) |
|
👀 |
Merged
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@amwat: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: kubernetes/kubernetes#68802
/cc @BenTheElder @ixdy
/area images
/hold