Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a presubmit e2e to kind #9591

Merged
merged 1 commit into from Sep 27, 2018
Merged

add a presubmit e2e to kind #9591

merged 1 commit into from Sep 27, 2018

Conversation

BenTheElder
Copy link
Member

so we can make sure things work :-)

I'll make it blocking at some point in the future...

/assign @krzyzacy @amwat

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 27, 2018
amwat
amwat reviewed Sep 27, 2018
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit af78f23 into kubernetes:master Sep 27, 2018
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap using the following files:

  • key kind-presubmit.yaml using file config/jobs/kubernetes-sigs/kind/kind-presubmit.yaml

In response to this:

so we can make sure things work :-)

I'll make it blocking at some point in the future...

/assign @krzyzacy @amwat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the kind-presubmit-e2e branch September 27, 2018 01:47
@BenTheElder BenTheElder added the area/kind Issues or PRs related to code in /kind label Sep 27, 2018
This was referenced Sep 27, 2018
Closed
Closed
BenTheElder
BenTheElder commented Sep 27, 2018
View reviewed changes
config/jobs/kubernetes-sigs/kind/kind-presubmit.yaml
- "--"
# the script must run from kubernetes, but we're checking out kind
- "bash"
- "-c"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gah, execute parses this as invalid flag >.>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #9592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat amwat left review comments

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@krzyzacy krzyzacy

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/kind Issues or PRs related to code in /kind cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenTheElder @k8s-ci-robot @amwat @krzyzacy