New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language labels for k/website repo #9835

Merged
merged 2 commits into from Oct 24, 2018

Conversation

@gochist
Member

gochist commented Oct 17, 2018

Allow anyone to add l10n labels for the issues or PRs in the k/website repo using label prow.

/cc @zacharysarah @tengqm @cstoku

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 17, 2018

Welcome @gochist! It looks like this is your first PR to kubernetes/test-infra 🎉🎉

@cblecker

This comment has been minimized.

Member

cblecker commented Oct 17, 2018

Adding it here will ensure the labels are created in the repo.. what it won't do is allow them to be added via the label plugin.

That would need to be changed here:

labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)
removeLabelRegex = regexp.MustCompile(`(?m)^/remove-(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)

@zacharysarah is it the intention to allow contributors to modify the language labels? I'm not against it, but would like to understand the intent before we modify things :)

@zacharysarah

This comment has been minimized.

Contributor

zacharysarah commented Oct 17, 2018

@cblecker 👋 I think the intent is to assign language labels via prow, for example:

/language en

The goal is to let contributors assign language labels to issues and PRs without also requiring them to have repo write permissions. It’s a quality of life enhancement specific to k/website, but boy howdy would it make a signicant improvement.

So yes, looks it would require the changes you mention. ☝️

@cblecker

This comment has been minimized.

Member

cblecker commented Oct 17, 2018

Yeah, then I'm personally fine with modifying those regexes.

@spiffxp @stevekuznetsov @fejta any thoughts/objections?

@gochist

This comment has been minimized.

Member

gochist commented Oct 24, 2018

Thank you, @cblecker and @zacharysarah . I added a commit to change the regexes.

@cblecker

This comment has been minimized.

Member

cblecker commented Oct 24, 2018

/lgtm
/assign @fejta

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 24, 2018

LGTM label has been added.

Git tree hash: acfbaba2f8d4020b9b042d46e14851aabb824439

@fejta

/hold
/lgtm

Feel free to /hold cancel if you don't want to split apart the PR

@@ -31,8 +31,8 @@ import (
const pluginName = "label"
var (
labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)
removeLabelRegex = regexp.MustCompile(`(?m)^/remove-(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)
labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|language|priority|sig|triage|wg)\s*(.*)$`)

This comment has been minimized.

@fejta

fejta Oct 24, 2018

Contributor

Might want to put this in its own PR

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 24, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Member

cblecker commented Oct 24, 2018

/hold cancel
I'm okay with this being the same PR. It's two separate commits, so it can be pulled apart that way if needed.

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 24, 2018

@gochist: Updated the label-config configmap using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Allow anyone to add l10n labels for the issues or PRs in the k/website repo using label prow.

/cc @zacharysarah @tengqm @cstoku

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 761277f into kubernetes:master Oct 24, 2018

12 checks passed

cla/linuxfoundation gochist authorized
Details
pull-test-infra-bazel Job succeeded.
Details
pull-test-infra-gubernator Skipped
pull-test-infra-lint Job succeeded.
Details
pull-test-infra-verify-bazel Job succeeded.
Details
pull-test-infra-verify-codegen Job succeeded.
Details
pull-test-infra-verify-config Job succeeded.
Details
pull-test-infra-verify-deps Skipped
pull-test-infra-verify-gofmt Job succeeded.
Details
pull-test-infra-verify-govet Job succeeded.
Details
pull-test-infra-verify-labels Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment