Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_e2e.py: don't exclude provider 'local' from gce_ssh #9915

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

neolit123
Copy link
Member

the latest runs of k-a jobs are failing with:

Something went wrong: failed to prepare test environment: stat /workspace/.ssh/google_compute_engine: no such file or directory

https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-kubeadm-gce-master/584

add a solution in kubernetest_e2e.py as suggested by @krzyzacy on slack:

would say for the actual local provider job, we won't mount the gce ssh key, so we are fine there.

/assign @krzyzacy @BenTheElder
/kind failing-test
/area kubetest

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. area/kubetest cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2018
@krzyzacy
Copy link
Member

/lgtm
/this-is-fine

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: dog image

In response to this:

/lgtm
/this-is-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38282751fe6a2a00c5b44c8c33b56380cb118a72

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@neolit123 neolit123 changed the title kubernetest_e2e.py: don't exclude provider 'local' from gce_ssh kubernetes_e2e.py: don't exclude provider 'local' from gce_ssh Oct 25, 2018
@neolit123
Copy link
Member Author

for xref:
kubernetes/kubernetes#70139
kubernetes/kubernetes#70058

FYI @timothysc we had to make another change, hopefully this time things go 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubetest cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants