Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate traces behind log level 2 #301

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

dgrisonnet
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Traces are now only dumped in logs if klog verbosity level is >= 2. Prior to this change, they were outputted to logs even when the verbosity level was set to 0 although this level should only be dedicated to critical information. Level 2 is better suited for information about requests.

Which issue(s) this PR fixes:

Fixes kubernetes/kubernetes#115993

Special notes for your reviewer:

Release note:

Traces are now outputted to logs only if the verbosity level is >= 2

Traces are now only dumped in logs if klog verbosity level is >= 2.
Prior to this change, they were outputted to logs even when the
verbosity level was set to 0 although this level should only be
dedicated to critical information. Level 2 is better suited for
information about requests.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2024
@dgrisonnet
Copy link
Member Author

/cc @sttts

@sttts
Copy link
Contributor

sttts commented Apr 23, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@dims
Copy link
Member

dims commented Apr 23, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, dims, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0849a56 into kubernetes:master Apr 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace messages from API Server with log verbosity of 0
4 participants