Adds UT for trace package in utils

[ashishranjan738]

Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com

This PR adds UT for trace package in utils repository

fixes: #69

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ashishranjan738]

/assign @dims

[ashishranjan738]

/assign @deads2k

[dims]

@ashishranjan738

• LogIfLong() is not tested ... if we add say 3 steps and the 2nd step takes longer than the other two, then the 2nd step would be logged essentially
• Log() needs to be tested too ... if there are n steps then the logs should have all the steps

[ashishranjan738]

@ashishranjan738

• LogIfLong() is not tested ... if we add say 3 steps and the 2nd step takes longer than the other two, then the 2nd step would be logged essentially
• Log() needs to be tested too ... if there are n steps then the logs should have all the steps

@dims
Added but I think we should not test these methods as these methods don't mutate any state they just logs some info. Ref : https://stackoverflow.com/questions/22606307/how-to-unit-test-a-function-that-does-not-return-anything

[dims]

@ashishranjan738 please do add tests for the above :) we want to simulate how we use the methods so we don't break the contract when we make changes to the code in this repo.

[dims]

/hold

[ashishranjan738]

@dims added the tests for Log and LogIfLong in the second commit as requested.

[dims]

@ashishranjan738 thanks! please squash the commits and we can proceed

[ashishranjan738]

@dims done

[dims]

/approve
/hold cancel

will leave others who have reviewed this for lgtm

[andrewsykim]

Few more comments, lgtm otherwise :)

[andrewsykim]

/lgtm

Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, ashishranjan738, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment