Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render list of releases using a content adapter #46426

Open
sftim opened this issue May 17, 2024 · 5 comments
Open

Render list of releases using a content adapter #46426

sftim opened this issue May 17, 2024 · 5 comments
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@sftim
Copy link
Contributor

sftim commented May 17, 2024

This is a Feature Request

What would you like to be added
Partially Revise https://kubernetes.io/releases/ to have some pages rendered using a content adapter.

For example:

Why is this needed
It provides a better place and “one stop shop” for people who want to find out about our releases, new and old.

Comments
/area web-development
/sig release

We would need to be using Hugo v0.126 or later.

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2024
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes sig/release Categorizes an issue or PR as relevant to SIG Release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim
Copy link
Contributor Author

sftim commented May 17, 2024

We should only make this change if we think it's a good idea.

@dipesh-rawat
Copy link
Member

+1 from me for this. This looks like a nice feature to incorporate.

@PushkarJ
Copy link
Member

PushkarJ commented May 26, 2024

This is a great idea. I want to try this for kubernetes/sig-security#1 to auto-generate CVE pages.

Can I request SIG Docs to create a container image that supports this new feature in v0.126.0? Getting this error right now:

personal-macbook:website pushkarj$ make container-serve
"docker" run --rm --interactive --tty --volume "/Users/pushkarj/opensource-ftw/kubernetes/website:/src:ro,Z" --cap-drop=ALL --cap-add=AUDIT_WRITE --read-only --mount type=tmpfs,destination=/tmp,tmpfs-mode=01777 -p 1313:1313 gcr.io/k8s-staging-sig-docs/k8s-website-hugo:v0.126.0-663380dd60a2 hugo server --buildFuture --environment development --bind 0.0.0.0 --destination /tmp/hugo --cleanDestinationDir --noBuildLock
Unable to find image 'gcr.io/k8s-staging-sig-docs/k8s-website-hugo:v0.126.0-663380dd60a2' locally
docker: Error response from daemon: manifest for gcr.io/k8s-staging-sig-docs/k8s-website-hugo:v0.126.0-663380dd60a2 not found: manifest unknown: Failed to fetch "v0.126.0-663380dd60a2" from request "/v2/k8s-staging-sig-docs/k8s-website-hugo/manifests/v0.126.0-663380dd60a2".

@sftim
Copy link
Contributor Author

sftim commented May 29, 2024

I've messaged you @PushkarJ about how to preview the site with a different Hugo version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants