Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gates reference page does not link to docs about enabling feature gates #46889

Open
vsagar100 opened this issue Jun 19, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@vsagar100
Copy link

The page does not at all talk how to enable it. If detailed steps are added then it would be helpful

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 19, 2024
@vsagar100
Copy link
Author

@sftim
Copy link
Contributor

sftim commented Jun 19, 2024

/retitle Feature gates reference page does not link to docs about enabling feature gates
/kind feature
/language en

@k8s-ci-robot k8s-ci-robot changed the title Feature Gates Feature gates reference page does not link to docs about enabling feature gates Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language labels Jun 19, 2024
@sftim
Copy link
Contributor

sftim commented Jun 19, 2024

/priority backlog
/triage accepted

To work on this issue, write a new task page that explains, per component:

  • how to tell where a feature gate is applicable (eg kubelet, kube-apiserver, kube-proxy)
  • how to enable a feature gate in that component

and then have the feature gates list hyperlink to that new task page.


Extra credit (needs design work): also change the feature gate shortcode to link to that new task page.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 19, 2024
@dshebib
Copy link
Contributor

dshebib commented Jun 25, 2024

how to enable a feature gate in that component

This seems relatively straightforward, but

how to tell where a feature gate is applicable (eg kubelet, kube-apiserver, kube-proxy)

This doesn't seem trivial, off the top of my head you'd have to just check each feature gate and what it does and enable it accordingly. Any ideas for how to do this other than just recommend it be enabled on every component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants