Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual stack 1.20 docs update #24725

Merged
merged 1 commit into from Nov 11, 2020
Merged

Dual stack 1.20 docs update #24725

merged 1 commit into from Nov 11, 2020

Conversation

bridgetkromhout
Copy link
Member

@bridgetkromhout bridgetkromhout commented Oct 26, 2020 •
edited

Dual stack services PR: kubernetes/kubernetes#91824
Dual stack support enhancement issue: kubernetes/enhancements#563

Please review.

Signed-off-by: Bridget Kromhout bridget@kromhout.org
Co-authored-by: Tim Bannister tim@scalefactory.com
Co-authored-by: Lachlan Evenson lachlan.evenson@microsoft.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 8a3244f

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fab100b181c9c0007af911f

@bridgetkromhout
Copy link
Member Author

/milestone 1.20

@k8s-ci-robot
Copy link
Contributor

@bridgetkromhout: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2020
@annajung
Copy link
Contributor

/milestone 1.20
/sig network
/hold
pending merge of kubernetes/kubernetes#91824
/cc @reylejano-rxm

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 26, 2020
@sftim sftim marked this pull request as draft October 26, 2020 21:36
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2020
@annajung
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@lachie83 lachie83 mentioned this pull request Oct 28, 2020
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2020
sftim
sftim reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bridgetkromhout

I hope this feedback is helpful. Some details are just style guide suggestions and are optional. Other suggestions I made are aiming to help the reader understand dual-stack operation.

content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Nov 4, 2020

/hold
Please squash commits when ready (BTW this repo preserves “LGTM” labels through squashes) and feel free to remove this hold once squashed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@irvifa
Copy link
Member

irvifa commented Nov 4, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 4, 2020
sftim
sftim reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation LGTM. Some style nits, I can pick those up once this merges.
Ready for tech review from SIG Network.

@reylejano
Copy link
Member

reylejano commented Nov 10, 2020 •
edited

@kubernetes/sig-network-pr-reviews can you provide a technical review (lgtm)?

@bridgetkromhout @sftim @lachie83
Dual-stack docs for Kubernetes 1.20
8a3244f 
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Lachlan Evenson <lachlan.evenson@microsoft.com>
@khenidak
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 114e130e72b93c3097fd009c98a98fd73f55cf18

thockin
thockin reviewed Nov 11, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@bridgetkromhout
Copy link
Member Author

/assign sftim

irvifa
irvifa reviewed Nov 11, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit b2bac63 into kubernetes:dev-1.20 Nov 11, 2020
@reylejano
Copy link
Member

Hi @bridgetkromhout @lachie83 , since this feature will be alpha for 1.20 does this feature need to be added to the Feature Gates list

@irvifa
Copy link
Member

irvifa commented Nov 11, 2020

@reylejano-rxm should we revert the PR first or make a follow up PR will suffice to fix this?
I’m sorry I forgot about the feature gate list.

@kbhawkey
Copy link
Contributor

Hi @irvifa .
I am guessing that there will be a follow-up PR. I suggest to leave this PR merged.
There is time to fix a few remaining docs issues before the release.

@sftim
Copy link
Contributor

sftim commented Nov 13, 2020

https://kubernetes.io/docs/concepts/services-networking/dual-stack/ already mentions feature gates, right?

1 similar comment
@sftim

This comment has been minimized.

Sign in to view
@raghvenders
Copy link
Contributor

raghvenders commented Nov 13, 2020 •
edited

it is already in alpha since v1.16 - "IPv6DualStack" , looks fine right...

But the feature gate list in the above mentioned page- https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ , rather it has to be https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features?

@sftim
Copy link
Contributor

sftim commented Nov 14, 2020

IPv6DualStack has been in alpha since v1.16 and is still in alpha. https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features looks right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@thockin thockin thockin left review comments

@irvifa irvifa irvifa left review comments

@raghvenders raghvenders raghvenders left review comments

@sftim sftim sftim left review comments

@annajung annajung annajung left review comments

@aramase aramase Awaiting requested review from aramase

@reylejano reylejano Awaiting requested review from reylejano

@lachie83 lachie83 Awaiting requested review from lachie83

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@thockin thockin

@khenidak khenidak

@sftim sftim

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.

None yet