Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiB Documentation - outer-loop Labs #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mindlessroman
Copy link

Purpose of PR

Based off of #24 - Just the outerlabs

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes
  • Codespaces changes

@mindlessroman mindlessroman changed the title PiB Documentation: outer-loop Labs PiB Documentation - outer-loop Labs Oct 31, 2022
@@ -17,115 +17,124 @@ git branch --show-current

## Login to Azure

- Login to Azure using `az login --use-device-code`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use bulleted lists throughout the document. Changing to normal text will remove consistency unless we change every doc which isn't feasible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I did go through all the different labs and made them sentence-based instead of bullet lists in #24 but since I'm breaking these up into smaller PRs, it may seem more scattered. I'm still trying to get a few more smaller PRs in over the next few days.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mindlessroman - Apologies for the delay here. We discussed as a team and we'd prefer to keep the style/formatting as-is, since it is what we have been used to conforming to in all of our repo/docs. If you get a chance, please revert the style/formatting changes but keep any wording/script improvements.

Thank you for contributing here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants