Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web pods always is set to 1 in UI #48

Closed
james-martinez opened this issue Dec 19, 2022 · 4 comments · Fixed by #58
Closed

Web pods always is set to 1 in UI #48

james-martinez opened this issue Dec 19, 2022 · 4 comments · Fixed by #58
Assignees
@mms-gianni
Labels
bug Something isn't working
Milestone
v1.4.2

Comments

@james-martinez
Copy link
Contributor

james-martinez commented Dec 19, 2022 •
edited
Loading

When setting up an app in the UI, I turn web pods to 0 and worker pods to 1 but web pods still return 1 when the app generates the Kuberoapp .
Screenshot 2022-12-19 at 9 35 03 AM
Screenshot 2022-12-19 at 9 41 10 AM
@mms-gianni
Copy link
Member

I will try to reproduce that.

@mms-gianni
Copy link
Member

Wow. That's strange. Got the same effect all the time.

@mms-gianni mms-gianni self-assigned this Dec 20, 2022
@mms-gianni mms-gianni added the bug Something isn't working label Dec 20, 2022
@mms-gianni
Copy link
Member

And here is the bug :
https://github.com/kubero-dev/kubero/blob/main/client/src/components/apps/new.vue#L799

0 is handled as false and transformed to 1

I will fix this in v1.4.2

@mms-gianni mms-gianni added this to the v1.4.2 milestone Dec 20, 2022
@james-martinez
Copy link
Contributor Author

#58

@mms-gianni mms-gianni linked a pull request Dec 21, 2022 that will close this issue
fix Web pods always is set to 1 in UI #48 #58
Merged
mms-gianni added a commit that referenced this issue Dec 22, 2022
@mms-gianni
Merge pull request #58 from james-martinez/fix/web-replicas
c4b85cb 
fix Web pods always is set to 1 in UI #48
james-martinez added a commit to james-martinez/kubero that referenced this issue Dec 22, 2022
@james-martinez
Forgot min replicas in kubero-dev#48 and kubero-dev#58
e0cd883
mms-gianni added a commit that referenced this issue Dec 22, 2022
@mms-gianni
Merge pull request #59 from james-martinez/fix/web-replicas
e4d796b 
Forgot min replicas in #48 and #58
@james-martinez james-martinez mentioned this issue Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mms-gianni mms-gianni

Labels
bug Something isn't working
Projects
Roadmap
Status: Done
Milestone
v1.4.2
Development

Successfully merging a pull request may close this issue.

fix Web pods always is set to 1 in UI #48
2 participants
@james-martinez @mms-gianni