Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load buildPipeline enabled from store #296

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

nicolaiort
Copy link
Contributor

Hi,

I noticed that the buildPipeline var/property on the app settings page wasn't loaded from the right store.
This resulted in the "Dockerfile" and "Nixpacks" build types never being available in the UI.

I just removed the staticly set var and replaced the mapState (which loaded the flag from buildPipeline instead of kubero.buildPipeline) with a read from the kubero store.
Now the build types get enabled/disabled based on the store setting and a change of the value in the pinia store (achieved using the Vue Devtools Extension in my browser) instantly enables/disables the "Dockerfile" and "Nixpacks" build types.

@mms-gianni mms-gianni added this to the v2.1.0 milestone Mar 17, 2024
@mms-gianni mms-gianni merged commit 4479ed9 into kubero-dev:main Mar 18, 2024
2 checks passed
@mms-gianni
Copy link
Member

Holy. Thank you for pointing this out. I was not aware of it. Works perfectly with your bugfix.

I decided to create another Bugfix tag to deploy it asap.

@mms-gianni mms-gianni self-assigned this Mar 22, 2024
@mms-gianni mms-gianni added the enhancement New feature or request label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants