Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for code reviews instead with PRs #32

Merged
merged 4 commits into from Apr 3, 2023
Merged

Support for code reviews instead with PRs #32

merged 4 commits into from Apr 3, 2023

Conversation

HollowMan6
Copy link
Contributor

Now, the example workflow supports automatically suggest fixes to pushes by opening new PRs and pull requests by code review instead.

Check PRs at https://github.com/HollowMan6/test-kubescape-github-action/pulls for the tests I have down.

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@vladklokun
Copy link
Contributor

Hi and thank you for your contribution!

Regarding the PR, it looks good to me on a quick glance. However, we need to agree which way we want to suggest fixes: using the comments in the original PR or a separate PR. So I have forwarded this to our Product team. Once we have that decision, I will come back to you with any comments I may or may not have.

HollowMan6 and others added 2 commits March 31, 2023 15:50
Signed-off-by: Hollow Man <hollowman@opensuse.org>
@github-advanced-security
Copy link

You have successfully added a new kubescape configuration .github/workflows/example-scan.yaml:kubescape. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new kubescape configuration .github/workflows/example-scan.yaml:kubescape-scan. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@dwertent dwertent merged commit 0e3a230 into kubescape:main Apr 3, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants