Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intergrate fix with comments #41

Merged
merged 2 commits into from May 2, 2023
Merged

Intergrate fix with comments #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bd836b
Bump kubescape version into v2.3.0
github-actions[bot] May 1, 2023
ece0288
Intergrate fix with comments
HollowMan6 Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/example-fix.yaml
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ jobs:

steps:
- uses: actions/checkout@v3
if: github.event_name != 'pull_request_target'
with:
fetch-depth: 0
- uses: actions/checkout@v3
Expand All @@ -32,6 +33,13 @@ jobs:
files: ${{ steps.changed-files.outputs.all_changed_files }}
fixFiles: true
format: "sarif"
# Use HollowMan6/sarif4reviewdog to support SARIF format for reviewdog
- name: PR Suggester by SARIF file
if: github.event_name == 'pull_request_target'
uses: HollowMan6/sarif4reviewdog@v1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigbox Should we move this action to the Kubescape org?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is not bonded to kubescape and can act as a general converter from sarif to rdf, but I'm OK if you want to do so.

with:
file: 'results.sarif'
level: warning
- uses: peter-evans/create-pull-request@v4
# Remember to allow GitHub Actions to create and approve pull requests
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
@@ -1,4 +1,4 @@
FROM quay.io/kubescape/kubescape:v2.2.6
FROM quay.io/kubescape/kubescape:v2.3.0

# Kubescape uses root privileges for writing the results to a file
USER root
Expand Down
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -60,6 +60,7 @@ jobs:

steps:
- uses: actions/checkout@v3
if: github.event_name != 'pull_request_target'
with:
fetch-depth: 0
- uses: actions/checkout@v3
Expand All @@ -77,6 +78,13 @@ jobs:
files: ${{ steps.changed-files.outputs.all_changed_files }}
fixFiles: true
format: "sarif"
# # Use HollowMan6/sarif4reviewdog to support SARIF format for reviewdog
# - name: PR Suggester by SARIF file
# if: github.event_name == 'pull_request_target'
# uses: HollowMan6/sarif4reviewdog@v1.0.0
# with:
# file: 'results.sarif'
# level: warning
- uses: peter-evans/create-pull-request@v4
# Remember to allow GitHub Actions to create and approve pull requests
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests
Expand Down