Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bumps start PRs instead of committing directly #42

Merged
merged 1 commit into from May 2, 2023
Merged

Version bumps start PRs instead of committing directly #42

merged 1 commit into from May 2, 2023

Conversation

HollowMan6
Copy link
Contributor

This PR change the version bumping workflow into the follows to resolve

Now the workflow gets triggered by committing into main branch or manually.

  • If any of the new release in the upstream is found, we start a new PR and get the docker image version bumped.
  • If the image version is bumped and no corresponding version tag is found in this repository, the workflow makes a new release for this action.

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6
Copy link
Contributor Author

@dwertent dwertent merged commit dfcc7e1 into kubescape:main May 2, 2023
5 checks passed
@HollowMan6 HollowMan6 deleted the release branch May 10, 2023 19:45
@HollowMan6
Copy link
Contributor Author

@dwertent As a follow up of this PR, would you please set this repository to allow GitHub Actions to create and approve pull requests? https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests

The workflow is failing and it shows that "Error: GitHub Actions is not permitted to create or approve pull requests." https://github.com/kubescape/github-action/actions/runs/4940978328/jobs/8833162723

@craigbox
Copy link
Contributor

craigbox commented Dec 7, 2023

I've updated the org and the repo to allow creating/approving pull requests from an action.

@craigbox
Copy link
Contributor

craigbox commented Dec 7, 2023

#54
The commit doesn't have the DCO applied, so I fixed that in the file.

#56
Has created a valid PR.

I am in favour of making this PR auto-merge. @TRohit20 can help with that :)

@TRohit20
Copy link

TRohit20 commented Dec 8, 2023

Yes, I reckon the action can be triggered with every release to check the version, update automatically if any different. Wdyt? @craigbox

I can work on automating this.

@HollowMan6
Copy link
Contributor Author

I can work on automating this.

Nice
#38 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants