Adding details to the spinner message #14
Merged
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dwertent
commented
Aug 10, 2023
•
dwertent
commented
- The spinner will print the IDetailed messages
- Updating printers emojis
Signed-off-by: David Wertenteil <dwertent@armosec.io>
matthyx
approved these changes
Aug 10, 2023
craigbox
reviewed
Aug 11, 2023
| @@ -103,12 +100,19 @@ func getSymbol(level string) string { | |||
| case "warning": | |||
| return "❗ " | |||
| case "success": | |||
| return "✔️ " | |||
| return "✅ " | |||
| default: | ||
| return "〜 " | ||
| return "ℹ️ " |
There was a problem hiding this comment.
renders no spaces after
because it's a double width character and OS X terminal is dumb.
let's see how Minikube does this, and probably put a space before all the emoji to ensure we get this right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.